Code Review for 2015-01-26

Prepared by: (jeffpc) on 2015-Jan-26 17:25 -0500 EST
Workspace:/home/jeffpc/illumos/arm/illumos-gate (at 75e27ad11e2a)
Compare against: arm-gate (at a117837708ca)
Summary of changes: 309 lines changed: 111 ins; 14 del; 184 mod; 2861 unchg
Patch of changes: 2015-01-26.patch
Printable review: 2015-01-26.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw README.xbuild

README: tell people how to execute the built files
53 lines changed: 48 ins; 3 del; 2 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_arm.c

libdisasm: print push/pop register list in a more human readable form
Instead of just blindly dumping a list of registers, we detect ranges and
print a list of ranges.
libdisasm: print r9 as "fp"
libdisasm: use "push" and "pop" when appropriate
While there is nothing technically wrong with printing the actual
instruction, it is easier on the eyes to just use these common aliases.
libdisasm: remove shouting
There's no need to print everything upper case.
247 lines changed: 62 ins; 5 del; 180 mod; 2375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/bcm2835/ml/locore.s

bcm2835: move strict alignment check disable code into the loader
Since the loader wants to muck with alignment related bits of the SCTLR
anyway, it should set both A and U to the desired values (0 and 1
respectively).
5 lines changed: 0 ins; 5 del; 0 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/loader/fakeloader_core.s

bcm2835: move strict alignment check disable code into the loader
Since the loader wants to muck with alignment related bits of the SCTLR
anyway, it should set both A and U to the desired values (0 and 1
respectively).
2 lines changed: 1 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/ml/trap.s

trap: don't mislead about SCTLR.V being not set
It's been quite a while since the exception table got moved via the high
vector bit (SCTLR.V).
2 lines changed: 0 ins; 1 del; 1 mod; 127 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.