Code Review for 2015-02-12

Prepared by: (jeffpc) on 2015-Feb-12 20:32 -0500 EST
Workspace:/home/jeffpc/illumos/arm/illumos-gate (at e7a54da6f904)
Compare against: HEAD^^^^^^ (at 330a17326839)
Summary of changes: 58 lines changed: 32 ins; 15 del; 11 mod; 1262 unchg
Patch of changes: 2015-02-12.patch
Printable review: 2015-02-12.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/loader/fakeloader.c

loader: allow 1MB device maps
There's no reason we shouldn't allow 1MB PTEs for use on device memory.
loader: map as much as possible using 1MB pages
Chances are that we never actually executed this bit of code since all the
maps we ever deal with are either very short or much larger than 1MB.
unix: enable caches in locore
The loader should really be as simple as possible to be as small as
possible.  It should configure the machine so that unix can make certain
assumptions but it should leave more complex initialization to unix.
18 lines changed: 7 ins; 4 del; 7 mod; 702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/loader/fakeloader_core.s

loader: document the page table setup
loader: simplify MMU enabling code
12 lines changed: 7 ins; 2 del; 3 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/ml/cache.s

armv6: p15 cache functions say that value passed in should be zero
4 lines changed: 4 ins; 0 del; 0 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/ml/glocore.s

unix: enable caches in locore
The loader should really be as simple as possible to be as small as
possible.  It should configure the machine so that unix can make certain
assumptions but it should leave more complex initialization to unix.
24 lines changed: 14 ins; 9 del; 1 mod; 196 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.