Code Review for armv6-bcm2835-qvpb-have-nearly-identical-locore-_start

Prepared by: (jeffpc) on 2015-Feb-07 18:57 -0500 EST
Workspace:/home/jeffpc/illumos/arm/illumos-gate (at 4031c147e905)
Compare against: HEAD^ (at be41c49dd212)
Summary of changes: 252 lines changed: 65 ins; 175 del; 12 mod; 183 unchg
Patch of changes: armv6-bcm2835-qvpb-have-nearly-identical-locore-_start.patch
Printable review: armv6-bcm2835-qvpb-have-nearly-identical-locore-_start.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/bcm2835/ml/locore.s

armv6: bcm2835 & qvpb have nearly identical locore _start
It makes sense to common-ize _start for all armv6 machines.  They will all
have to do the same basic setup.  If there is any machine specific setup
they need to do, they can do so in the new _mach_start function.
91 lines changed: 0 ins; 88 del; 3 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/ml/glocore.s

armv6: bcm2835 & qvpb have nearly identical locore _start
It makes sense to common-ize _start for all armv6 machines.  They will all
have to do the same basic setup.  If there is any machine specific setup
they need to do, they can do so in the new _mach_start function.
69 lines changed: 64 ins; 0 del; 5 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/qvpb/ml/locore.s

armv6: bcm2835 & qvpb have nearly identical locore _start
It makes sense to common-ize _start for all armv6 machines.  They will all
have to do the same basic setup.  If there is any machine specific setup
they need to do, they can do so in the new _mach_start function.
92 lines changed: 1 ins; 87 del; 4 mod; 19 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.