Code Review for bcm2835-use-the-real-uart-instead-of-the-mini-uart

Prepared by: (jeffpc) on 2015-Feb-07 18:57 -0500 EST
Workspace:/home/jeffpc/illumos/arm/illumos-gate (at 55618b1fe22c)
Compare against: HEAD^ (at 75e27ad11e2a)
Summary of changes: 457 lines changed: 199 ins; 218 del; 40 mod; 212 unchg
Patch of changes: bcm2835-use-the-real-uart-instead-of-the-mini-uart.patch
Printable review: bcm2835-use-the-real-uart-instead-of-the-mini-uart.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/bcm2835/Makefile.files

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
3 lines changed: 1 ins; 1 del; 1 mod; 22 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/bcm2835/loader/bcm2835_ldep.c

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
80 lines changed: 19 ins; 29 del; 32 mod; 123 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/armv6/bcm2835/os/bcm2835_uart.c

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/armv6/bcm2835/os/bcm2835_uart.h

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/bcm2835/os/boot_console.c

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
7 lines changed: 0 ins; 0 del; 7 mod; 67 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/armv6/bcm2835/os/miniuart.c (deleted)

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
150 lines changed: 0 ins; 150 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/armv6/bcm2835/os/miniuart.h (deleted)

bcm2835: use the real uart instead of the mini-uart
The real uart is more capable.  We'll want to use it for the real console
eventually anyway, so let's bite the bullet now when no one will really
notice.  (For comparison, the Linux kernel uses the real uart and totally
lacks a driver for the miniuart.)
38 lines changed: 0 ins; 38 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.