Code Review for folded

Prepared by: (jeffpc) on 2015-Jan-14 19:07 -0500 EST
Workspace:/home/jeffpc/illumos/arm/illumos-gate (at 80bf5b6b2466)
Compare against: arm-gate (at 32ea9b319737)
Summary of changes: 98 lines changed: 59 ins; 21 del; 18 mod; 3799 unchg
Patch of changes: folded.patch
Printable review: folded.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw README.xbuild

README.xbuild update
6 lines changed: 5 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_arm.c

libdisasm: fully decode DPI immediate
The immediate value can be rotated.  Instead of dumping the 8-bit immediate
and 4-bit rotate field, we should dump the effective immediate value (both
in decimal and hex) to ease reading the disassembly.  This matches GNU
objdump behavior.
10 lines changed: 6 ins; 0 del; 4 mod; 2546 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/ml/glocore.s

_locore_start needs to set up an 8-byte aligned stack
Sadly, during removal of special early-boot stacks
(027eb01d0ff8f66be55208b58ecd7cb2b7b27714) the stack passed into mlsetup
lost its 8-byte aligned-ness.
10 lines changed: 5 ins; 0 del; 5 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/os/fakebop.c

fakebop: make a note of multiple ATAG_MEM
fakebop: dump ATAG_ILLUMOS_{STATUS,MAPPING}
fakebop: make the atag dumping code a bit more readable
71 lines changed: 43 ins; 21 del; 7 mod; 865 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/armv6/sys/atag.h

atag: remove whitespace error
1 line changed: 0 ins; 0 del; 1 mod; 123 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.