Code Review for 4266-makefile-shared

Prepared by:Jeff (jeffpc) on 2013-Dec-14 21:35 -0500 EST
Workspace:/home/jeffpc/illumos/build-cleanup (at e6ee6a4b3fa8)
Compare against: HEAD^ (at 1bcffb7155a8)
Summary of changes: 9478 lines changed: 4180 ins; 5148 del; 150 mod; 1495 unchg
Patch of changes: 4266-makefile-shared.patch
Printable review: 4266-makefile-shared.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/README

4266 remove Makefile*.shared nonsense in uts
4 lines changed: 0 ins; 4 del; 0 mod; 314 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/inc.flg

4266 remove Makefile*.shared nonsense in uts
2 lines changed: 0 ins; 2 del; 0 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/inc.flg

4266 remove Makefile*.shared nonsense in uts
6 lines changed: 0 ins; 6 del; 0 mod; 135 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.i86pc

4266 remove Makefile*.shared nonsense in uts
304 lines changed: 299 ins; 0 del; 5 mod; 25 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/i86pc/Makefile.i86pc.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
329 lines changed: 0 ins; 329 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
19 lines changed: 16 ins; 1 del; 2 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/i86pc/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/Makefile.i86xpv

4266 remove Makefile*.shared nonsense in uts
294 lines changed: 290 ins; 0 del; 4 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/i86xpv/Makefile.i86xpv.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
320 lines changed: 0 ins; 320 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
18 lines changed: 15 ins; 1 del; 2 mod; 25 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/i86xpv/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel

4266 remove Makefile*.shared nonsense in uts
691 lines changed: 686 ins; 1 del; 4 mod; 31 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/Makefile.intel.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
714 lines changed: 0 ins; 714 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
16 lines changed: 13 ins; 0 del; 3 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/kmech_krb5/req.flg

4266 remove Makefile*.shared nonsense in uts
2 lines changed: 0 ins; 2 del; 0 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/Makefile.sparc

4266 remove Makefile*.shared nonsense in uts
470 lines changed: 466 ins; 0 del; 4 mod; 32 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sparc/Makefile.sparc.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
494 lines changed: 0 ins; 494 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
18 lines changed: 15 ins; 0 del; 3 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sparc/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/kmech_krb5/req.flg

4266 remove Makefile*.shared nonsense in uts
2 lines changed: 0 ins; 2 del; 0 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/req.flg

4266 remove Makefile*.shared nonsense in uts
2 lines changed: 0 ins; 2 del; 0 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun/io/scsi/inc.flg

4266 remove Makefile*.shared nonsense in uts
2 lines changed: 0 ins; 2 del; 0 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/Makefile.sun4u

4266 remove Makefile*.shared nonsense in uts
455 lines changed: 448 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/Makefile.sun4u.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
476 lines changed: 0 ins; 476 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
22 lines changed: 19 ins; 0 del; 3 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/blade/Makefile.blade

4266 remove Makefile*.shared nonsense in uts
101 lines changed: 94 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/blade/Makefile.blade.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
122 lines changed: 0 ins; 122 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/blade/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
59 lines changed: 52 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/blade/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/grover/Makefile.grover

4266 remove Makefile*.shared nonsense in uts
63 lines changed: 56 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/grover/Makefile.grover.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
84 lines changed: 0 ins; 84 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/grover/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
59 lines changed: 52 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/grover/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/javelin/Makefile.javelin

4266 remove Makefile*.shared nonsense in uts
56 lines changed: 49 ins; 2 del; 5 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/javelin/Makefile.javelin.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/javelin/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
61 lines changed: 54 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/javelin/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
82 lines changed: 0 ins; 82 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/montecarlo/Makefile.montecarlo

4266 remove Makefile*.shared nonsense in uts
77 lines changed: 70 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/montecarlo/Makefile.montecarlo.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
100 lines changed: 0 ins; 100 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/montecarlo/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
71 lines changed: 64 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/montecarlo/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/mpxu/Makefile.mpxu

4266 remove Makefile*.shared nonsense in uts
106 lines changed: 98 ins; 3 del; 5 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/mpxu/Makefile.mpxu.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/mpxu/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
77 lines changed: 69 ins; 3 del; 5 mod; 21 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/mpxu/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
95 lines changed: 0 ins; 95 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/opl/Makefile.opl

4266 remove Makefile*.shared nonsense in uts
159 lines changed: 154 ins; 2 del; 3 mod; 23 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/opl/Makefile.opl.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
180 lines changed: 0 ins; 180 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/opl/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
80 lines changed: 75 ins; 2 del; 3 mod; 23 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/opl/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
101 lines changed: 0 ins; 101 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/Makefile.serengeti

4266 remove Makefile*.shared nonsense in uts
128 lines changed: 121 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/serengeti/Makefile.serengeti.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
150 lines changed: 0 ins; 150 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
75 lines changed: 68 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/serengeti/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
96 lines changed: 0 ins; 96 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/starcat/Makefile.starcat

4266 remove Makefile*.shared nonsense in uts
134 lines changed: 127 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/starcat/Makefile.starcat.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
157 lines changed: 0 ins; 157 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/starcat/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
75 lines changed: 68 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/starcat/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
96 lines changed: 0 ins; 96 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/sunfire/Makefile.sunfire

4266 remove Makefile*.shared nonsense in uts
55 lines changed: 52 ins; 0 del; 3 mod; 28 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/sunfire/Makefile.sunfire.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
83 lines changed: 0 ins; 83 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/sunfire/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
52 lines changed: 48 ins; 0 del; 4 mod; 27 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/sunfire/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
79 lines changed: 0 ins; 79 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/tazmo/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
59 lines changed: 52 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/tazmo/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/tazmo/Makefile.tazmo

4266 remove Makefile*.shared nonsense in uts
67 lines changed: 60 ins; 2 del; 5 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4u/tazmo/Makefile.tazmo.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
87 lines changed: 0 ins; 87 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/Makefile.sun4v

4266 remove Makefile*.shared nonsense in uts
418 lines changed: 411 ins; 1 del; 6 mod; 22 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4v/Makefile.sun4v.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
439 lines changed: 0 ins; 439 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/Makefile.targ

4266 remove Makefile*.shared nonsense in uts
22 lines changed: 19 ins; 0 del; 3 mod; 26 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/sun4v/Makefile.targ.shared (deleted)

4266 remove Makefile*.shared nonsense in uts
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.