Print this page
5047 don't use atomic_*_nv if you discard the return value

@@ -1583,11 +1583,11 @@
         DB_DNODE_ENTER(db);
         dn = DB_DNODE(db);
         dndb = dn->dn_dbuf;
         if (db->db_blkid != DMU_BONUS_BLKID && MUTEX_HELD(&dn->dn_dbufs_mtx)) {
                 list_remove(&dn->dn_dbufs, db);
-                (void) atomic_dec_32_nv(&dn->dn_dbufs_count);
+                atomic_dec_32(&dn->dn_dbufs_count);
                 membar_producer();
                 DB_DNODE_EXIT(db);
                 /*
                  * Decrementing the dbuf count means that the hold corresponding
                  * to the removed dbuf is no longer discounted in dnode_move(),

@@ -1806,11 +1806,11 @@
 
                         DB_DNODE_ENTER(db);
                         dn = DB_DNODE(db);
                         mutex_enter(&dn->dn_dbufs_mtx);
                         list_remove(&dn->dn_dbufs, db);
-                        (void) atomic_dec_32_nv(&dn->dn_dbufs_count);
+                        atomic_dec_32(&dn->dn_dbufs_count);
                         mutex_exit(&dn->dn_dbufs_mtx);
                         DB_DNODE_EXIT(db);
                         /*
                          * Decrementing the dbuf count means that the hold
                          * corresponding to the removed dbuf is no longer

@@ -2091,11 +2091,11 @@
                         /*
                          * If the dnode moves here, we cannot cross this barrier
                          * until the move completes.
                          */
                         DB_DNODE_ENTER(db);
-                        (void) atomic_dec_32_nv(&DB_DNODE(db)->dn_dbufs_count);
+                        atomic_dec_32(&DB_DNODE(db)->dn_dbufs_count);
                         DB_DNODE_EXIT(db);
                         /*
                          * The bonus buffer's dnode hold is no longer discounted
                          * in dnode_move(). The dnode cannot move until after
                          * the dnode_rele().