Print this page
5047 don't use atomic_*_nv if you discard the return value

*** 1418,1439 **** cmi_hdl_rele(cmi_hdl_t ophdl) { cmi_hdl_impl_t *hdl = IMPLHDL(ophdl); ASSERT(*hdl->cmih_refcntp > 0); ! (void) atomic_dec_32_nv(hdl->cmih_refcntp); } void cmi_hdl_destroy(cmi_hdl_t ophdl) { cmi_hdl_impl_t *hdl = IMPLHDL(ophdl); cmi_hdl_ent_t *ent; /* Release the reference count held by cmi_hdl_create(). */ ASSERT(*hdl->cmih_refcntp > 0); ! (void) atomic_dec_32_nv(hdl->cmih_refcntp); hdl->cmih_flags |= CMIH_F_DEAD; ent = cmi_hdl_ent_lookup(hdl->cmih_chipid, hdl->cmih_coreid, hdl->cmih_strandid); /* --- 1418,1439 ---- cmi_hdl_rele(cmi_hdl_t ophdl) { cmi_hdl_impl_t *hdl = IMPLHDL(ophdl); ASSERT(*hdl->cmih_refcntp > 0); ! atomic_dec_32(hdl->cmih_refcntp); } void cmi_hdl_destroy(cmi_hdl_t ophdl) { cmi_hdl_impl_t *hdl = IMPLHDL(ophdl); cmi_hdl_ent_t *ent; /* Release the reference count held by cmi_hdl_create(). */ ASSERT(*hdl->cmih_refcntp > 0); ! atomic_dec_32(hdl->cmih_refcntp); hdl->cmih_flags |= CMIH_F_DEAD; ent = cmi_hdl_ent_lookup(hdl->cmih_chipid, hdl->cmih_coreid, hdl->cmih_strandid); /*