Code Review for 5291-x86-highbit-lowbit-rely-on-undefined-behavior

Prepared by: (jeffpc) on 2014-Nov-14 18:05 -0500 EST
Workspace:/home/jeffpc/illumos/intel-asm (at 0483225d09c8)
Compare against: master (at 5009f7885e2c)
Summary of changes: 94 lines changed: 21 ins; 59 del; 14 mod; 4915 unchg
Patch of changes: 5291-x86-highbit-lowbit-rely-on-undefined-behavior.patch
Printable review: 5291-x86-highbit-lowbit-rely-on-undefined-behavior.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/amd64/ml/amd64.il

5291 x86 {high,low}bit rely on undefined behavior
9 lines changed: 0 ins; 9 del; 0 mod; 222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/asm/bitmap.h

5291 x86 {high,low}bit rely on undefined behavior
14 lines changed: 4 ins; 0 del; 10 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/ml/i86_subr.s

patch keith-feedback
5291 x86 {high,low}bit rely on undefined behavior
53 lines changed: 17 ins; 32 del; 4 mod; 4403 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/ml/ia32.il

5291 x86 {high,low}bit rely on undefined behavior
18 lines changed: 0 ins; 18 del; 0 mod; 200 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.