Print this page
4804 apix & pcplusmp are nearly warning free already
Tentatively Reviewed by: Robert Mustacchi <rm@joyent.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/i86pc/io/mp_platform_misc.c
          +++ new/usr/src/uts/i86pc/io/mp_platform_misc.c
↓ open down ↓ 545 lines elided ↑ open up ↑
 546  546                  apic_free_vector(irqptr->airq_vector);
 547  547                  return (PSM_SUCCESS);
 548  548          }
 549  549          /*
 550  550           * Downgrade vector to new max_ipl if needed. If we cannot allocate,
 551  551           * use old IPL. Not very elegant, but it should work.
 552  552           */
 553  553          if ((irqptr->airq_ipl != max_ipl) && (max_ipl != PSM_INVALID_IPL) &&
 554  554              !ioapic_mask_workaround[irqptr->airq_ioapicindex]) {
 555  555                  apic_irq_t      *irqp;
 556      -                if (vector = apic_allocate_vector(max_ipl, irqno, 1)) {
      556 +                if ((vector = apic_allocate_vector(max_ipl, irqno, 1))) {
 557  557                          apic_mark_vector(irqheadptr->airq_vector, vector);
 558  558                          irqp = irqheadptr;
 559  559                          while (irqp) {
 560  560                                  irqp->airq_vector = vector;
 561  561                                  irqp->airq_ipl = (uchar_t)max_ipl;
 562  562                                  if (irqp->airq_temp_cpu != IRQ_UNINIT) {
 563  563                                          apic_record_rdt_entry(irqp, irqindex);
 564  564  
 565  565                                          iflag = intr_clear();
 566  566                                          lock_set(&apic_ioapic_lock);
↓ open down ↓ 1647 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX