Print this page
patch tsoome-feedback

@@ -269,11 +269,10 @@
         if (fmd_nvl_fmri_unusable(hdl, asru)) {
                 nvlist_free(asru);
                 return (1);
         }
 
-        if (asru != NULL)
                 nvlist_free(asru);
 
         return (0);
 }
 

@@ -324,11 +323,10 @@
 
         page = gmem_page_lookup(afar);
         if (page != NULL) {
                 if (page->page_flags & GMEM_F_FAULTING ||
                     gmem_page_unusable(hdl, page)) {
-                        if (rsc != NULL)
                                 nvlist_free(rsc);
                         page->page_flags |= GMEM_F_FAULTING;
                         return (0);
                 }
         } else {

@@ -343,11 +341,10 @@
         if (nvlist_lookup_nvlist(page->page_asru_nvl, FM_FMRI_HC_SPECIFIC,
             &hsp) == 0)
                 (void) nvlist_add_nvlist(rsc, FM_FMRI_HC_SPECIFIC, hsp);
 
         flt = fmd_nvl_create_fault(hdl, GMEM_FAULT_PAGE, 100, NULL, fru, rsc);
-        if (rsc != NULL)
                 nvlist_free(rsc);
 
         if (nvlist_add_boolean_value(flt, FM_SUSPECT_MESSAGE, B_FALSE) != 0)
                 fmd_hdl_abort(hdl, "failed to add no-message member to fault");