Code Review for big-webrev

Prepared by:Jeff (jeffpc) on 2014-May-05 14:29 -0400 EDT
Workspace:/home/jeffpc/illumos/ibdm (at 7769e46f5c74)
Compare against: master (at cb3e7fb42f81)
Summary of changes: 202 lines changed: 46 ins; 60 del; 96 mod; 96850 unchg
Patch of changes: big-webrev.patch
Printable review: big-webrev.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/ddi_get_time.9f

4776 man: don't lie about ddi_get_time(9f) uses
Reviewed by: Robert Mustacchi <rm@joyent.com>
8 lines changed: 5 ins; 0 del; 3 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/ip_fil_solaris.c

4787 ipf: remove rate_limit_message
38 lines changed: 0 ins; 38 del; 0 mod; 2861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/iscsit/iscsit.c

4780 comstar iSCSI target shouldn't abuse ddi_get_time(9f)
Reviewed by: Eric Diven <eric.diven@delphix.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 0 ins; 0 del; 4 mod; 3427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/emlxs/emlxs_dhchap.c

4786 emlxs shouldn't abuse ddi_get_time(9f)
5 lines changed: 3 ins; 0 del; 2 mod; 9843 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/emlxs/emlxs_solaris.c

4786 emlxs shouldn't abuse ddi_get_time(9f)
2 lines changed: 1 ins; 0 del; 1 mod; 11543 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/mgt/ibdm/ibdm.c

4777 ibdm shouldn't abuse ddi_get_time(9f)
Reviewed by: Rob Gittins <rob.gittins@nexenta.com>
Reviewed by: Albert Lee <albert.lee@nexenta.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
51 lines changed: 8 ins; 15 del; 28 mod; 7264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/iprb/iprb.c

4778 iprb shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Garrett D'Amore <garrett@damore.org>
11 lines changed: 1 ins; 1 del; 9 mod; 1789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/iprb/iprb.h

4778 iprb shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Garrett D'Amore <garrett@damore.org>
9 lines changed: 1 ins; 0 del; 8 mod; 365 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/mac/mac_protect.c

4788 mac shouldn't abuse ddi_get_time(9f)
16 lines changed: 3 ins; 2 del; 11 mod; 2291 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/scsi_vhci/scsi_vhci.c

4779 vhci shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
11 lines changed: 3 ins; 1 del; 7 mod; 8810 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/targets/sd.c

4781 sd shouldn't abuse ddi_get_time(9f)
Reviewed by: Richard Elling <richard.elling@gmail.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
8 lines changed: 1 ins; 3 del; 4 mod; 31815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/usba/hubdi.c

4782 usba shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
7 lines changed: 1 ins; 0 del; 6 mod; 9103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fibre-channel/fca/emlxs/emlxs_device.h

4786 emlxs shouldn't abuse ddi_get_time(9f)
4 lines changed: 3 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fibre-channel/fca/emlxs/emlxs_dhchap.h

4786 emlxs shouldn't abuse ddi_get_time(9f)
5 lines changed: 3 ins; 0 del; 2 mod; 808 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fibre-channel/fca/emlxs/emlxs_fc.h

4786 emlxs shouldn't abuse ddi_get_time(9f)
4 lines changed: 3 ins; 0 del; 1 mod; 2158 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/mgt/ibdm/ibdm_ibnex.h

4777 ibdm shouldn't abuse ddi_get_time(9f)
Reviewed by: Rob Gittins <rob.gittins@nexenta.com>
Reviewed by: Albert Lee <albert.lee@nexenta.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 3 ins; 0 del; 1 mod; 415 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/idm/idm_impl.h

4780 comstar iSCSI target shouldn't abuse ddi_get_time(9f)
Reviewed by: Eric Diven <eric.diven@delphix.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 0 ins; 0 del; 2 mod; 537 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/adapters/scsi_vhci.h

4779 vhci shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
6 lines changed: 3 ins; 0 del; 3 mod; 864 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/targets/sddef.h

4781 sd shouldn't abuse ddi_get_time(9f)
Reviewed by: Richard Elling <richard.elling@gmail.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 2417 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/hubd/hubdvar.h

4782 usba shouldn't abuse ddi_get_time(9f)
Reviewed by: Robert Mustacchi <rm@joyent.com>
5 lines changed: 3 ins; 0 del; 2 mod; 431 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.