Code Review for use-NULL-getmemid-segop-as-a-shorthand-for-ENODEV

Prepared by: (jeffpc) on 2015-May-08 18:04 -0400 EDT
Workspace:/home/jeffpc/illumos/xhat (at 9c7ebe49bb23)
Compare against: HEAD^ (at c02cdfbc1373)
Summary of changes: 28 lines changed: 1 ins; 26 del; 1 mod; 7776 unchg
Patch of changes: use-NULL-getmemid-segop-as-a-shorthand-for-ENODEV.patch
Printable review: use-NULL-getmemid-segop-as-a-shorthand-for-ENODEV.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kp.c

use NULL getmemid segop as a shorthand for ENODEV
Instead of forcing every segment driver to implement a dummy function to
return (hopefully) ENODEV, handle NULL getmemid segop function pointer as
"return ENODEV" shorthand.
9 lines changed: 0 ins; 9 del; 0 mod; 1405 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kpm.c

use NULL getmemid segop as a shorthand for ENODEV
Instead of forcing every segment driver to implement a dummy function to
return (hopefully) ENODEV, handle NULL getmemid segop function pointer as
"return ENODEV" shorthand.
1 line changed: 0 ins; 1 del; 0 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vm_as.c

use NULL getmemid segop as a shorthand for ENODEV
Instead of forcing every segment driver to implement a dummy function to
return (hopefully) ENODEV, handle NULL getmemid segop function pointer as
"return ENODEV" shorthand.
7 lines changed: 0 ins; 7 del; 0 mod; 3530 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vm_seg.c

use NULL getmemid segop as a shorthand for ENODEV
Instead of forcing every segment driver to implement a dummy function to
return (hopefully) ENODEV, handle NULL getmemid segop function pointer as
"return ENODEV" shorthand.
2 lines changed: 1 ins; 0 del; 1 mod; 2046 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/v9/vm/seg_nf.c

use NULL getmemid segop as a shorthand for ENODEV
Instead of forcing every segment driver to implement a dummy function to
return (hopefully) ENODEV, handle NULL getmemid segop function pointer as
"return ENODEV" shorthand.
9 lines changed: 0 ins; 9 del; 0 mod; 465 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.